RFR: 8276721: G1: Refine G1EvacFailureObjectsSet::iterate [v2]

Hamlin Li mli at openjdk.java.net
Tue Nov 9 09:26:38 UTC 2021


On Tue, 9 Nov 2021 06:50:57 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Currently, G1EvacFailureObjectsSet::iterate(ObjectClosure* closure) is not a const method, but it looks like a const method. It will be a surprise for reader, i.e. you would not expect that an iteration method is destructive, clearing out the set it just iterated over.
>> We should refine it in some way.
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typos

I was thinking handle_iteration() will be not that surprising for users as iterate(), but seems it's not.
Sure, let me just rename it as process_and_drop.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6303



More information about the hotspot-gc-dev mailing list