RFR: 8277807: Increase default initial concurrent refinement threshold [v2]

Stefan Johansson sjohanss at openjdk.java.net
Tue Nov 30 10:30:12 UTC 2021


On Tue, 30 Nov 2021 08:32:50 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright
>
> src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp line 258:
> 
>> 256:     // rate_1 is a relatively conservative guess at the rate for pause-time
>> 257:     // card refinement by one thread.
>> 258:     const double rate_1 = 200.0; // cards/ms/thread
> 
> I would prefer if this magic number were placed somewhere more standing out than in some static method in a cpp file. I thought at least put it into the .hpp file as part of the `G1ConcurrentRefine" class. However there are no guidelines for that for g1 code where or how to collect these magic constants I'm kind of good with that too.

I agree with Thomas. I think this should live in `G1ConcurrentRefine`, but if you don't agree I'm ok with leaving as is.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6549



More information about the hotspot-gc-dev mailing list