RFR: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
Thomas Schatzl
tschatzl at openjdk.java.net
Tue Oct 5 11:53:05 UTC 2021
On Tue, 5 Oct 2021 11:49:26 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Please review this fix of the test, eliminating a race that could
>> unexpectedly leave buffers in the "completed" list after all the threads
>> have shut down.
>>
>> Testing:
>> mach5 tier1
>
> test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp line 191:
>
>> 189: return;
>> 190: } else if (!Atomic::load_acquire(_continue_running)) {
>> 191: // To avoid a race that could leave buffers in the list after this
>
> s/avoid/handle/ (or something similar).
>
> The change does not eliminate (or avoids) the race, but handles the (not logic-breaking) results of the race.
Suggestion:
// To handle a benign race that could leave buffers in the list after this
-------------
PR: https://git.openjdk.java.net/jdk/pull/5820
More information about the hotspot-gc-dev
mailing list