RFR: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm

[Kim Barrett]

On Tue, 5 Oct 2021 11:50:57 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp line 191:
>> 
>>> 189:         return;
>>> 190:       } else if (!Atomic::load_acquire(_continue_running)) {
>>> 191:         // To avoid a race that could leave buffers in the list after this
>> 
>> s/avoid/handle/ (or something similar).
>> 
>> The change does not eliminate (or avoids) the race, but handles the (not logic-breaking) results of the race.
>
> Suggestion:
> 
>         // To handle a benign race that could leave buffers in the list after this

The race involved is not a benign data race, it's a logic race that's not at all benign.  I could describe the race in more detail if you want.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5820