RFR: 8272773: Investigate making card table size configurable [v3]
Vishal Chand
github.com+10235864+vish-chan at openjdk.java.net
Sun Oct 10 12:49:11 UTC 2021
On Thu, 7 Oct 2021 11:13:14 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Vishal Chand has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Merge branch 'card-size-configurable' of https://github.com/vish-chan/jdk into card-size-configurable
>> - Changes as per the first set of comments
>
> src/hotspot/share/gc/shared/cardTable.cpp line 468:
>
>> 466: uintx CardTable::ct_max_alignment_constraint() {
>> 467: // CardTable max alignment is computed with card_size_max
>> 468: return card_size_max * os::vm_page_size();
>
> I think this change causes some tests to fail because their heap will get too large. Maybe it is possible to move code so that the actual card size value is used here to avoid this, or fix the errors (will be visible with enabled github actions).
I don't see any errors after enabling the tests via github actions. Am I missing something here?
-------------
PR: https://git.openjdk.java.net/jdk/pull/5838
More information about the hotspot-gc-dev
mailing list