request for review - 6806046 (XXS)

[Coleen Phillimore - Sun Microsystems]

Ivan, Did you get reviews?  It looks okay to me, a few more backslashes 
never hurt.
Are you going to check this into hotspot-rt repository?
Thanks!
Coleen

On 02/18/09 04:16, Ivan Krylov wrote:
> Sorry, this fix should be
> +        sysDefines.add("HOTSPOT_LIB_ARCH=\\\"i486\\\"");
> Ivan
>
> Ivan Krylov wrote:
>> Hi,
>>
>> This is a fix for CR 6806046.
>>
>> There is a file that we keep in the repository called create.bat
>> This file creates a Visual Studio project using java code from 
>> share\tools\MakeDeps
>> At some point compilation of vm got broken in such generated projects.
>>
>> This is the error message:
>> src\share\vm\compiler\disassembler.cpp(34) : error C2146: syntax 
>> error : missing ';' before identifier 'HOTSPOT_LIB_ARCH'
>> src\share\vm\compiler\disassembler.cpp(34) : fatal error C1004: 
>> unexpected end of file found
>>
>> Clearly it is because HOTSPOT_LIB_ARCH is not defined in the 
>> preprocessor definitions if the project properties.
>>
>> Since we do not use the IDE for production binaries this 
>> functionality is secondary.
>>
>> Still this 1-line fix is worth integrating, imo.
>>
>> === *Suggested Fix* 
>> ==========================================================
>> --- old/src/share/tools/MakeDeps/BuildConfig.java    Mon Feb 16 
>> 18:25:13 2009
>> +++ new/src/share/tools/MakeDeps/BuildConfig.java    Mon Feb 16 
>> 18:25:13 2009
>> @@ -247,6 +247,7 @@
>>         
>  sysDefines.add("HOTSPOT_BUILD_USER="+System.getProperty("user.name"));
>          sysDefines.add("HOTSPOT_BUILD_TARGET=\\\""+get("Build")+"\\\"");
>          sysDefines.add("_JNI_IMPLEMENTATION_");
>  +        sysDefines.add("HOTSPOT_LIB_ARCH=\\\"i486\\\"");
>          sysDefines.addAll(defines);
>>
>> Thanks,
>>
>> Ivan
>>
>> PS There is a file to create a VS project for 64-bit vm but I was not 
>> updated for years. I will look into it later.
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>