code review request for JVM/TI CompiledMethodLoad event extension (6580131)

Tom Rodriguez tom.rodriguez at oracle.com
Mon May 3 16:22:13 PDT 2010 

They are resource allocated so they don't need to be free'd.  The destructor of ResourceMark will release any storage that was allocated.

tom

On May 3, 2010, at 3:47 PM, Jeremy Manson wrote:

> Resurrecting an old thread...
> 
> Is there any reason that no one ever frees the arrays that are created
> by this changeset in create_inline_record() in jvmtiExport.cpp?  Or am
> I just missing where they are freed?
> 
> I don't think they are freed elsewhere...  I added a method that
> performed some obvious freeing at the end of
> post_compiled_method_load(), ran a CompileTheWorld, and it seemed to
> work okay...
> 
> Jeremy
> 
> On Wed, Jan 20, 2010 at 6:30 PM, Daniel D. Daugherty
> <Daniel.Daugherty at sun.com> wrote:
>> Greetings,
>> 
>> The jvmticmlr.h stuff is in:
>> 
>> - OpenJDK6 - JDK and HotSpot sides
>> - JDK7 - JDK side
>> - HSX17 - HotSpot side
>> 
>> When HSX17-B08 pushes to JDK7, then the HotSpot side will
>> be in JDK7 also.
>> 
>> We'll be looking at the JDK6-Update train next...
>> 
>> Dan
>> 
>> 
>> 
>> 
>> Daniel D. Daugherty wrote:
>>> 
>>> Greetings,
>>> 
>>> The folks at AMD Labs have been kind enough to provide an
>>> extension to the JVM/TI CompileMethodLoad event in order
>>> to provide additional information about in-lining. This
>>> extension uses the existing (but previously unused)
>>> compile_info paramter:
>>> 
>>> 
>>> http://java.sun.com/javase/6/docs/platform/jvmti/jvmti.html#CompiledMethodLoad
>>> 
>>> Vasanth and company provided the HotSpot code changes and
>>> the original demo program. I just did the Makefile changes
>>> to export the new jvmticmlr.h file in the HotSpot repo and
>>> the integration of the demo program into JAVA_HOME/demo/jvmti
>>> in the JDK repo.
>>> 
>>> Here is the webrev for the OpenJDK6 version of the changes:
>>> 
>>>   http://cr.openjdk.java.net/~dcubed/6580131-webrev/0/
>>> 
>>> The OpenJDK7 version of these changes are not expected to be
>>> very different from this version.
>>> 
>>> For the Sun folks, the CCC request for adding the jvmticmlr.h
>>> is almost final. I'm waiting for the VM-SQE team to agree that
>>> the latest version addresses their review concerns, but I
>>> think the St Petersburg team is on holiday at the moment.
>>> 
>>> Any reviews are appreciated.
>>> 
>>> Dan
>>> 
>> 
>> 
>> ---------- Forwarded message ----------
>> From: Daniel.Daugherty at Sun.COM
>> To: jdk6-dev at openjdk.java.net
>> Date: Wed, 20 Jan 2010 20:14:48 +0000
>> Subject: hg: jdk6/jdk6/hotspot: 2 new changesets
>> Changeset: 7fbf850d87b7
>> Author:    dcubed
>> Date:      2010-01-13 09:39 -0700
>> URL:       http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/7fbf850d87b7
>> 
>> 6580131: 3/4 CompiledMethodLoad events don't produce the expected extra
>> notifications to describe inlining
>> Summary: Add support for additional implementation specific info to the
>> JVM/TI CompiledMethodLoad event via the compile_info parameter.
>> Reviewed-by: never, ohair, tbell, tdeneau
>> Contributed-by: Vasanth Venkatachalam <vasanth.venkatachalam at amd.com>
>> 
>> ! make/Makefile
>> ! make/defs.make
>> + src/share/vm/code/jvmticmlr.h
>> ! src/share/vm/includeDB_core
>> ! src/share/vm/prims/jvmtiExport.cpp
>> 
>> Changeset: 7dbe24cb959c
>> Author:    dcubed
>> Date:      2010-01-20 10:35 -0700
>> URL:       http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/7dbe24cb959c
>> 
>> Merge
>> 
>> ! make/Makefile
>> ! make/defs.make
>> ! src/share/vm/includeDB_core
>> ! src/share/vm/prims/jvmtiExport.cpp
>> 
>> 
>> 
>> 
>> ---------- Forwarded message ----------
>> From: Daniel.Daugherty at Sun.COM
>> To: jdk7-changes at openjdk.java.net, hotspot-runtime-dev at openjdk.java.net,
>> serviceability-dev at openjdk.java.net
>> Date: Wed, 20 Jan 2010 21:10:36 +0000
>> Subject: hg: jdk7/hotspot-rt/hotspot: 2 new changesets
>> Changeset: 7fbf850d87b7
>> Author:    dcubed
>> Date:      2010-01-13 09:39 -0700
>> URL:
>> http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/7fbf850d87b7
>> 
>> 6580131: 3/4 CompiledMethodLoad events don't produce the expected extra
>> notifications to describe inlining
>> Summary: Add support for additional implementation specific info to the
>> JVM/TI CompiledMethodLoad event via the compile_info parameter.
>> Reviewed-by: never, ohair, tbell, tdeneau
>> Contributed-by: Vasanth Venkatachalam <vasanth.venkatachalam at amd.com>
>> 
>> ! make/Makefile
>> ! make/defs.make
>> + src/share/vm/code/jvmticmlr.h
>> ! src/share/vm/includeDB_core
>> ! src/share/vm/prims/jvmtiExport.cpp
>> 
>> Changeset: 3908ad124838
>> Author:    dcubed
>> Date:      2010-01-20 11:32 -0700
>> URL:
>> http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/3908ad124838
>> 
>> Merge
>> 
>> ! make/Makefile
>> ! make/defs.make
>> ! src/share/vm/includeDB_core
>> ! src/share/vm/prims/jvmtiExport.cpp
>> 
>> 
>> 
>> 
>> ---------- Forwarded message ----------
>> From: Daniel.Daugherty at Sun.COM
>> To: jdk6-dev at openjdk.java.net
>> Date: Wed, 20 Jan 2010 22:10:34 +0000
>> Subject: hg: jdk6/jdk6/jdk: 2 new changesets
>> Changeset: 6073840fbd22
>> Author:    dcubed
>> Date:      2010-01-13 09:42 -0700
>> URL:       http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/6073840fbd22
>> 
>> 6580131: 3/4 CompiledMethodLoad events don't produce the expected extra
>> notifications to describe inlining
>> Summary: Add support for additional implementation specific info to the
>> JVM/TI CompiledMethodLoad event via the compile_info parameter.
>> Reviewed-by: never, ohair, tbell, tdeneau
>> Contributed-by: Vasanth Venkatachalam <vasanth.venkatachalam at amd.com>
>> 
>> ! make/common/shared/Sanity.gmk
>> ! make/java/jvm/Makefile
>> ! make/mkdemo/jvmti/Makefile
>> ! make/mkdemo/jvmti/README.txt
>> + make/mkdemo/jvmti/compiledMethodLoad/Makefile
>> + src/share/demo/jvmti/compiledMethodLoad/README.txt
>> + src/share/demo/jvmti/compiledMethodLoad/compiledMethodLoad.c
>> + src/share/demo/jvmti/compiledMethodLoad/sample.makefile.txt
>> ! src/share/demo/jvmti/index.html
>> + src/share/javavm/export/jvmticmlr.h
>> + test/demo/jvmti/compiledMethodLoad/CompiledMethodLoadTest.java
>> ! test/demo/jvmti/heapTracker/HeapTrackerTest.java
>> ! test/demo/jvmti/hprof/CpuTimesDefineClassTest.java
>> ! test/demo/jvmti/hprof/CpuTimesTest.java
>> ! test/demo/jvmti/minst/MinstTest.java
>> ! test/demo/jvmti/mtrace/TraceJFrame.java
>> 
>> Changeset: b2510c4f0228
>> Author:    dcubed
>> Date:      2010-01-20 11:47 -0700
>> URL:       http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/b2510c4f0228
>> 
>> Merge
>> 
>> 
>> 
>> 
>> 
>> ---------- Forwarded message ----------
>> From: Daniel.Daugherty at Sun.COM
>> To: jdk7-changes at openjdk.java.net, compiler-dev at openjdk.java.net,
>> core-libs-dev at openjdk.java.net, serviceability-dev at openjdk.java.net,
>> security-dev at openjdk.java.net, net-dev at openjdk.java.net
>> Date: Wed, 20 Jan 2010 23:19:50 +0000
>> Subject: hg: jdk7/tl/jdk: 6580131: 3/4 CompiledMethodLoad events don't
>> produce the expected extra notifications to describe inlining
>> Changeset: b19cd193245e
>> Author:    dcubed
>> Date:      2010-01-20 12:09 -0700
>> URL:       http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b19cd193245e
>> 
>> 6580131: 3/4 CompiledMethodLoad events don't produce the expected extra
>> notifications to describe inlining
>> Summary: Add support for additional implementation specific info to the
>> JVM/TI CompiledMethodLoad event via the compile_info parameter.
>> Reviewed-by: never, ohair, tbell, tdeneau
>> Contributed-by: Vasanth Venkatachalam <vasanth.venkatachalam at amd.com>
>> 
>> ! make/common/shared/Sanity.gmk
>> ! make/java/jvm/Makefile
>> ! make/mkdemo/jvmti/Makefile
>> ! make/mkdemo/jvmti/README.txt
>> + make/mkdemo/jvmti/compiledMethodLoad/Makefile
>> + src/share/demo/jvmti/compiledMethodLoad/README.txt
>> + src/share/demo/jvmti/compiledMethodLoad/compiledMethodLoad.c
>> + src/share/demo/jvmti/compiledMethodLoad/sample.makefile.txt
>> ! src/share/demo/jvmti/index.html
>> + src/share/javavm/export/jvmticmlr.h
>> + test/demo/jvmti/compiledMethodLoad/CompiledMethodLoadTest.java
>> ! test/demo/jvmti/heapTracker/HeapTrackerTest.java
>> ! test/demo/jvmti/hprof/CpuTimesDefineClassTest.java
>> ! test/demo/jvmti/hprof/CpuTimesTest.java
>> ! test/demo/jvmti/minst/MinstTest.java
>> ! test/demo/jvmti/mtrace/TraceJFrame.java
>> 
>> 
>> 
>>

More information about the hotspot-runtime-dev mailing list