7009975: Large file support broken in hs20-b04

[Karen Kinnear]

Alan,

We would very much appreciate it if you could push this. And yes, the 
change looks
good.

I'd also be interested in your opinion as to whether we need to support 
the JVM_
socket related calls on Windows. It isn't clear to us how "private" that 
interface is
or whether customers are free to call the JVM_* APIs.

thanks,
Karen

On 01/04/11 14:05, Paul Hohensee wrote:
> Looks good.
>
> Paul
>
> On 1/4/11 2:01 PM, Alan Bateman wrote:
>> The changes to remove the dependency on the HPI in hs20-b04 has 
>> broken the large file support on Solaris. I think Ivan is on vacation 
>> at the moment so I'm wondering if I could just push a small patch 
>> (via jprt of course) to fix this. The patch just changes os::open 
>> (used by JVM_Open which is why it impacts java.io) to use open64 on 
>> Solaris.
>>
>> diff -r 36c186bcc085 src/os/solaris/vm/os_solaris.cpp
>> --- a/src/os/solaris/vm/os_solaris.cpp  Mon Jan 03 14:09:11 2011 -0500
>> +++ b/src/os/solaris/vm/os_solaris.cpp  Tue Jan 04 18:42:37 2011 +0000
>> @@ -5197,7 +5197,7 @@ int os::open(const char *path, int oflag
>>   int o_delete = (oflag & O_DELETE);
>>   oflag = oflag & ~O_DELETE;
>>
>> -  fd = ::open(path, oflag, mode);
>> +  fd = ::open64(path, oflag, mode);
>>   if (fd == -1) return -1;
>>
>>   //If the open succeeded, the file might still be a directory
>>
>> Thanks,
>>
>> -Alan