Request for review (S) 7009828: Fix for 6938627 breaks visualvm monitoring when -Djava.io.tmpdir is defined

Coleen Phillimore coleen.phillimore at oracle.com
Wed Jan 12 11:33:10 PST 2011


Thanks Alan for the review, jdk change and discussion about this bug!
Coleen

On 1/12/2011 2:24 PM, Alan Bateman wrote:
> Coleen Phillimore wrote:
>> Summary: Change get_temp_directory() back to /tmp and %TEMP% like it 
>> always was and where the tools expect it to be.
>>
>> There is more information in the bug, but essentially changing 
>> get_temp_directory() to use java.io.tmpdir breaks a lot of things.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/7009828/
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=7009828
>>
>> Thanks,
>> Coleen
>>
> This looks okay to me but does mean we'll need to partially back-out 
> 6950927 [1] from jdk7. I can do that for you. It will mean that the 
> test sun/management/jmxremote/bootstrap/JvmstatCountersTest.java will 
> fail until we meet up in a promoted build but I think we can live with 
> that (or just add the @ignore until both changes come together).
>
> -Alan
>
> [1] http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/17870c6c1d4e



More information about the hotspot-runtime-dev mailing list