RFR (XS): 8004691: Add a jtreg test that exercises the ExecuteInternalVMTests flag

Erik Helin erik.helin at oracle.com
Tue Dec 18 04:15:11 PST 2012


Hi Stefan,

thanks for reviewing this change! See comments inline:

On 12/18/2012 11:24 AM, Stefan Karlsson wrote:
> Looks good.

Thanks!

On 12/18/2012 11:24 AM, Stefan Karlsson wrote:
> Though, I'd prefer if the test was not put in the gc directory, since
> this flag could be used by all HotSpot groups.

I agree, I've moved the test to the hotspot/test/sanity folder instead.

The new webrev is located at:
http://cr.openjdk.java.net/~ehelin/8004691/webrev.01/

I've also updated some spelling errors.

Thanks,
Erik

> thanks,
> StefanK
>
> On 12/18/2012 10:52 AM, Erik Helin wrote:
>> Hi all,
>>
>> this change adds a jtreg test that runs the internal vm tests.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8004691/webrev.00/
>>
>> Summary:
>> There are a couple of tests in HotSpot C++ source code that can be run
>> with the flag -XX:+ExecuteInternalVMTests. These tests are run in JPRT
>> queues, but they are not run as part of the nightly testing.
>>
>> This change adds an empty jtreg test that starts the VM with the flag
>> -XX:+ExecuteInternalVMTests, thereby running the internal VM tests.
>>
>> Since -XX:+ExecuteInternalVMTests only works with a non-product build of
>> the VM, the test also uses the flag -XX:+IgnoreUnrecognizedVMOptions to
>> make sure the test works, but does nothing, when run with a product
>> build of HotSpot.
>>
>> Testing:
>> JPRT
>>
>> Thanks,
>> Erik
>



More information about the hotspot-runtime-dev mailing list