Request for reviews (XXS): 7142167: MAC: _get_previous_fp broken on bsd with llvm-gcc

Christian Thalinger christian.thalinger at oracle.com
Thu Feb 2 10:31:05 PST 2012


On Feb 2, 2012, at 7:11 PM, Daniel D. Daugherty wrote:

> Thumbs up!
> 
> Any idea whether this is limited to Apple's llvm-gcc or is
> this generic to all of them?

Sorry, I don't know.  I only noticed there is something wrong in the generated assembly.

-- Chris

> 
> Dan
> 
> 
> On 2/2/12 10:44 AM, Christian Thalinger wrote:
>> http://cr.openjdk.java.net/~twisti/7142167/
>> 
>> 7142167: MAC: _get_previous_fp broken on bsd with llvm-gcc
>> Reviewed-by:
>> 
>> LLVM-GCC (__llvm__) should use the same _get_previous_fp
>> implementation as __clang__ (as is the case for
>> os::current_stack_pointer).
>> 
>> src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
>> 



More information about the hotspot-runtime-dev mailing list