Pls review 7142113: Add Ivy Bridge to the known Intel x86 cpu families (S)

[Daniel D. Daugherty]

Ahhhhhhh!!!!

Make sure you comment why you are doing that so someone down
the road doesn't "fix" it...

Dan



On 2/16/12 7:55 AM, Paul Hohensee wrote:
> You're welcome.
>
> I found a Sandy Bridge machine in the Intel collab farm that has a
> model number of 45, so I'm going to keep both the documented
> value of 42 and the apparently undocumented value of 45.
>
> New webrev here
>
> http://cr.openjdk.java.net/~phh/7142113.01/
>
> Absent objection, I'll push this version.
>
> Paul
>
> On 2/16/12 3:33 AM, Markus Grönlund wrote:
>> Looks good Paul, thanks for doing this.
>>
>> I can tick off the IvyBridge CPUID on my list.
>>
>> Cheers
>> Markus
>>
>>> -----Original Message-----
>>> From: Paul Hohensee
>>> Sent: den 16 februari 2012 03:44
>>> To: Karen Kinnear
>>> Cc: hotspot-runtime-dev at openjdk.java.net
>>> Subject: Re: Pls review 7142113: Add Ivy Bridge to the known Intel x86
>>> cpu families (S)
>>>
>>> Thank you, Karen,
>>>
>>> Paul
>>>
>>> On 2/15/12 8:08 PM, Karen Kinnear wrote:
>>>> Paul,
>>>>
>>>> Looks good - and thanks for fixing the SANDYBRIDGE id as well.
>>>>
>>>> thanks,
>>>> Karen
>>>>
>>>> On Feb 15, 2012, at 4:53 PM, Paul Hohensee wrote:
>>>>
>>>>> Webrev here
>>>>>
>>>>> http://cr.openjdk.java.net/~phh/7142113.00/
>>>>>
>>>>> Intel documentation (attached to the CR) says that the Ivy Bridge
>>> extended
>>>>> model number is 0x3a.
>>>>>
>>>>> I changed the cpuExtendedModel values from decimal to hex, since hex
>>> is
>>>>> what's used in the Intel documentation.  I also changed
>>> CPU_MODEL_SANDYBRIDGE_EP
>>>>> from 0x2d == 45 to the correct 0x2a and added *_EX model values for
>>>>> later use: see comment in is_intel_tsc_synced_at_init().
>>>>>
>>>>> Tested on a Sandy Bridge machine via debugging tty->print_cr().  I
>>> don't
>>>>> have access to an Ivy Bridge machine.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Paul
>>>>>
>>>>>