Pls review 7091418: FX priority class from Solaris should be available to JVM )

[Daniel D. Daugherty]

On 1/25/12 4:08 PM, Paul Hohensee wrote:
> New webrev at
>
> http://cr.openjdk.java.net/~phh/7091418.01/

Thumbs up!


Don't forget to use this bug ID when you commit:

     7082553 2/3 Interpret Thread.setPriority(Thread.MAX_PRIORITY) to mean
                 FX60 on Solaris 10 and 11

It would be nice to update the copyrights...


src/os/bsd/vm/os_bsd.cpp
     No comments.

src/os/linux/vm/os_linux.cpp
     No comments.

src/os/solaris/vm/osThread_solaris.hpp
     typo line 36: 'create' -> 'created'

src/os/solaris/vm/os_solaris.cpp
     nit line 3798 - deleted a blank line - why?

     lines 3998-4031 are pretty domain specific; I can't vouch for the
         correctness one way or the other

     lines 4000, 4012, 4022 seem a bit long

     nit lines 4036-7 - deleted blanks lines - why?

src/os/windows/vm/os_windows.cpp
     No comments.

src/share/vm/compiler/compileBroker.cpp
     No comments.

src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp
     line 78: The comment on line 75 in os.hpp says that the VMThread
         uses NearMaxPriority so this comment (nor the original
         comment) make sense.

src/share/vm/runtime/globals.hpp
     nit line 3491: "VM thread" -> "the VM thread"

src/share/vm/runtime/os.hpp
     Why am I reminded of the scene in "Spinal Tap" where they
     are talking about the amp that goes up to 11 instead of 10?

     No (real) comments.