RFR(XS) 8003591: Abstract_VM_Version::internal_vm_info_string needs to stringify FLOAT_ARCH for ease of use

David Holmes david.holmes at oracle.com
Tue Nov 20 20:56:36 PST 2012


http://cr.openjdk.java.net/~dholmes/8003591/webrev/

The internal version string can use the FLOAT_ARCH define to provide 
additional information regarding the floating-point architecture that 
was being built for. At present FLOAT_ARCH is required to be a string 
literal. This can be set at build time by using:

gcc -DFLOAT_ARCH="-my-arch"

However this becomes problematic if you want to set a make variable that 
will add the -D, or worse a script variable that sets a make variable 
that sets -D, because you have to provide a means to escape the 
string-ness of the value at each level so that we finally get a string 
literal as expected.

This fix changes things so that FLOAT_ARCH is not a string literal, but 
is converted to one using XSTR. So now you can specify

-DFLOAT_ARCH=-my-arch

regardless of how many layers of scripts or makefile invocations you 
have to survive.

Thanks,
David


More information about the hotspot-runtime-dev mailing list