RFR: JI-29: SA ClassDump throws exception after permgen removal

[Staffan Larsen]

I'm working on a change to remove all references to ia64/itanium in SA since it is dead code. It's ok with me if some references disappear before that.

/Staffan

On 3 okt 2012, at 00:52, David Holmes <David.Holmes at oracle.com> wrote:

> Hi Yumin,
> 
> Seems to be a lot of incidental cleanup here. What is the general state of ia64 files/references?
> 
> David
> 
> On 3/10/2012 3:12 PM, Yumin Qi wrote:
>> Hi, All
>> 
>>   Based on Coleen's feedback, sadis.c has compilation warning, fixed,
>> also removed some unused code in SA.
>> 
>> http://cr.openjdk.java.net/~minqi/8000332/
>> <http://cr.openjdk.java.net/%7Eminqi/8000332/>
>> 
>> Thanks
>> Yumin
>> 
>> On 10/2/2012 1:50 PM, Yumin Qi wrote:
>>> Hi, all
>>> 
>>>  This is real URL for this bug codereview, I accidentally created the
>>> bug with JIRA by click incidents link.  Now the link is
>>> http://cr.openjdk.java.net/~minqi/JDK-8000332/
>>> <http://cr.openjdk.java.net/%7Eminqi/JDK-8000332/>
>>> 
>>>  Thanks
>>>  Yumin
>>> 
>>> On 10/2/2012 10:33 AM, Yumin Qi wrote:
>>>> Hi, May I have your codereview
>>>> 
>>>> http://cr.openjdk.java.net/~minqi/ji-29
>>>> <http://cr.openjdk.java.net/%7Eminqi/ji-29/>
>>>> 
>>>> JI-29: SA ClassDump throws exception after permgen removal
>>>> Summary: In ClassWrite.writeFields(), fields count was set to fields
>>>> length which overflows the array index.
>>>> 
>>>> Also removed a file which should be removed in changeset of 6879063:
>>>> SA should use hsdis.
>>>> 
>>>> Reviewed-by:
>>>> Contributed-by: yumin.qi at oracle.com
>>>> 
>>>> 
>>>> Thanks
>>>> Yumin