RFR: 8000818: SA constant pool need to reference to reference map after permgen removal

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Fri Oct 19 00:30:51 PDT 2012


Looks good.

Thanks,
Serguei

On 10/18/12 1:27 PM, yumin.qi at oracle.com wrote:
>  Hi, all
>
>   Add _invokehandle which is missed in SA.  Its java code is 
> _invokevirtual which already processed in ClassWriter.
>   Same links.
>
> Thanks
> Yumin
>
> On 10/17/2012 5:25 PM, Yumin Qi wrote:
>> Hi,
>>
>>   As suggested by David, I created a new  bug
>>   8001055:  Bytes.swap should follow big endian
>>   to address the issued caused by 6879063 push.
>>
>>   new webrevs:
>>   http://cr.openjdk.java.net/~minqi/8000818
>>   http://cr.openjdk.java.net/~minqi/8001055
>>
>> Thanks
>> Yumin
>>
>> On 10/16/2012 9:51 PM, Yumin Qi wrote:
>>> Hi, all
>>>
>>>   May I have your codereview on
>>>
>>> http://cr.openjdk.java.net/~minqi/8000818/ 
>>> <http://cr.openjdk.java.net/%7Eminqi/8000818/>
>>>
>>> 8000818: SA constant pool need to reference to reference map after 
>>> permgen removal
>>> Summary: After permgen removal, constant pool changed to put _ldc 
>>> and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no 
>>> longer calculated via constant pool cache.
>>> Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap 
>>> should only check if the underlying platform is big endian  since 
>>> java code follows big endian.  Revert it back to its orginal form, 
>>> else it will fail  ClassDump.
>>>
>>> Reviewed-by:
>>> Contributed-by: yumin.qi at oracle.com
>>>
>>>
>>> Thanks
>>> Yumin



More information about the hotspot-runtime-dev mailing list