1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Tue Oct 30 10:42:19 PDT 2012


On 10/30/12 10:37 AM, Daniel D. Daugherty wrote:
> Thumbs up.

Thanks, Dan!
Serguei


>
> Is someone going to do an audit for similar missing changes
> from max_stack() (not max_size()) to verifier_max_stack()?
>
> Dan
>
>
> On 10/30/12 1:30 PM, serguei.spitsyn at oracle.com wrote:
>> Hello,
>>
>>
>> Please, review the fix for CR:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607
>>
>> CR in JIRA:
>> https://jbs.oracle.com/bugs/browse/JDK-7194607
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size
>>
>>
>> Summary:
>>
>> This issue is caused by the changes in the oops/method.hpp for 
>> invokedynamic (JSR 292).
>> Now the max_stack() adds +2 to the original code attribute stack size 
>> if invokedynamic is enabled.
>> The verifier_max_stack() must be used in the 
>> jvmtiClassFileReconstituter.cpp
>> instead of the max_size() to get the code attribute stack size.
>>
>>
>> Thanks,
>> Serguei
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20121030/5b66ad58/attachment-0001.html 


More information about the hotspot-runtime-dev mailing list