RFR (XS) 8010723 - possible deadlock with SystemDictionary_lock

[David Holmes]

Is there any way to express this:

839   // This need to be re-thought when parallel-capable non-boot
840   // classloaders are supported by CDS (today they're not).

as an assert?

David

On 30/03/2013 5:26 AM, Ioi Lam wrote:
> Coleen,
>
> I have updated the webrev to incorporate your comments:
>
> http://cr.openjdk.java.net/~iklam/8010723/sysdic_lock_002/
>
> Thanks
> - Ioi
>
> On 03/29/2013 10:38 AM, Coleen Phillimore wrote:
>>> // This must be done outside of the SystemDictionary_lock to
>>>     // avoid deadlock.
>>>     //
>>>     // Note that Klass::restore_unshareable_info (called via
>>>     // load_instance_class above) is also called outside
>>>     // of SystemDictionary_lock. All other threads that are
>>>     // trying to load this class in the boot classloader
>>>     // are already blocked above at
>>>     // if (class_loader.is_null()) {SystemDictionary_lock->wait();}
>> How about
>>
>>       // Other threads are blocked from loading this class because
>> they are
>>       // are waiting on the SystemDictionary_lock until this thread
>> removes
>>       // the placeholder below.
>>
>> thanks,
>> Coleen
>>>     //
>>>     // This need to be re-thought when parallel-capable non-boot
>>>     // classloaders are supported by CDS (today they're not).
>