Review request: 8010151 : nsk/regression/b6653214 fails "assert(snapshot != NULL) failed: Worker should not be started"
Coleen Phillimore
coleen.phillimore at oracle.com
Wed Apr 3 11:40:59 PDT 2013
Is the _snapshot volatile or what it points to is volatile? The code
you have is what it points to.
I think you want:
*! static_ _MemSnapshot* volatile _snapshot;*
Coleen
On 04/03/2013 01:59 PM, Zhengyu Gu wrote:
> The assertion appears due to snapshot variable still is not visible to
> worker thread, so make snapshot volatile.
>
> NMT creates snapshot before starting NMT worker thread and the
> snapshot is released by worker thread during shutdown, so the
> assertion should not fail. I can not reproduce the problem
> with/without volatile modifier.
>
>
> Bug: http://bugs.sun.com/view_bug.do?bug_id=8010151
> Webrev: http://cr.openjdk.java.net/~zgu/8010151/webrev.00/
> <http://cr.openjdk.java.net/%7Ezgu/8010151/webrev.00/>
>
> Test:
> nsk/regression/b6653214 on Windows x64
>
>
> Thanks,
>
> -Zhengyu
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130403/f282ec27/attachment.html
More information about the hotspot-runtime-dev
mailing list