Request for review: JDK-8011260: fatal error: LineNumberTable attribute has wrong length in class file

Coleen Phillimore coleen.phillimore at oracle.com
Wed Apr 10 12:06:16 PDT 2013


This looks good to me.  I was concerned that there isn't a ResourceMark 
in classFileParser.hpp where you added as_C_string() because generally 
you need that.  In this case it's a fatal so no need to recover the 
memory but if there isn't a ResourceMark in the caller, you'll get the 
"allocation outside a resource mark" assertion instead of the assertion 
you want.   So you should probably add it right before the as_C_string() 
call.

Coleen

On 4/9/2013 9:55 AM, harold seigel wrote:
> Hi,
>
> Please review the following bug fix:
>
> Summary:   The assertion was prevented by changing the code to verify 
> classes loaded by the anonymous class loader, unless -noverify was 
> specified.  Also, the relevant assertion messages were improved to 
> include additional information, including class name.
>
> Open webrev at http://cr.openjdk.java.net/~hseigel/bug_8011260/ 
> <http://cr.openjdk.java.net/%7Ehseigel/bug_8011260/>
>
> Bug link at http://bugs.sun.com/view_bug.do?bug_id=8011260
>
> The change was tested by hand to ensure that the assertion no longer 
> occurs when the test is run.  Additional testing was done using JCK 
> Lang and VM, JTREG tests, ute vm.quick.testlist and vm.mlvm.testlist 
> tests, and JPRT tests.
>
> Thank you!
> Harold



More information about the hotspot-runtime-dev mailing list