Request for review: JDK-8012052: java/lang/invoke/6987555/Test6987555.java crashes with assert(mcs != NULL) failed: MethodCounters cannot be NULL

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Apr 11 18:43:23 PDT 2013


Good.

Thanks,
Vladimir

On 4/11/13 5:39 PM, Jiangli Zhou wrote:
> Please review the following fix for JDK-8012052
> <https://jbs.oracle.com/bugs/browse/JDK-8012052>:
>
> http://cr.openjdk.java.net/~jiangli/8012052/webrev.00/
>
> The MethodCounters object is not guaranteed to be present for a method
> that is being compiled when NonTieredCompPolicy::delay_compilation() is
> called due to compiler shuts off. In
> java/lang/invoke/6987555/Test6987555 test case, the current method being
> compiled is java.lang.invoke.MethodHandle::linkToStatic(LL), which
> hasn’t been executed before and has no associated MethodCounters at the
> time. Since delay_compilation() decrements the _counter by dividing 2
> only if _counter >0, there is no need to call delay_compilation() when
> the method has no associated MethodCounters.
>
> Thanks,
> Jiangli


More information about the hotspot-runtime-dev mailing list