RFR: 8013117: Thread-local trace_buffer has wrong type and name

David Holmes david.holmes at oracle.com
Wed Apr 24 03:07:29 PDT 2013


Hi Rickard,

On 24/04/2013 5:51 PM, Rickard Bäckman wrote:
> Hi all,
>
> can I have a couple of reviews for this small change. The short story is that the current way the thread-local _trace_buffer is somewhat inflexible.
> By changing the type of the getter this structure gets more flexible for different implementations. I also think that the name is misused. Just naming it
> to _trace_data is more generic and less implementation-specific.
>
> The webrev: http://cr.openjdk.java.net/~rbackman/8013117/

It seems strange to get rid of the setter. How is it to be set? It isn't 
even initialized now.

David

> Thanks
> /R
>


More information about the hotspot-runtime-dev mailing list