RFR: 8009985: [parfait] Uninitialised variable at jdk/src/solaris/native/com/sun/management/UnixOperatingSystem_md.c

Peter Allwin peter.allwin at oracle.com
Wed Apr 24 05:09:09 PDT 2013


Indeed!

Thank you all for your reviews,

/peter
> ------------------------------------------------------------------------
>
> 	David Holmes <mailto:david.holmes at oracle.com>
> Wednesday, April 24, 2013 12:16 PM
>
>
> +1 from me but I'm surprised this code doesn't always report an error 
> - must be pure chance that the uninitialized value == KERN_SUCCESS
>
> David
>
>
> ------------------------------------------------------------------------
>
> 	Peter Allwin <mailto:peter.allwin at oracle.com>
> Wednesday, April 24, 2013 11:31 AM
>
>
> Hi all, I'm looking for reviews of this change:
>
> Parfait has identified an incorrect return code comparison in 
> UnixOperatingSystemMXBean getOpenFileDescriptorCount on OSX. Very 
> simple fix is to check against the correct variable.
>
> CR: http://cr.openjdk.java.net/~sla/peter/8009985/webrev.00/
> JBS: https://jbs.oracle.com/bugs/browse/JDK-8009985
>
>
> Thanks!
>
> /peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130424/2a6ef113/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: compose-unknown-contact.jpg
Type: image/jpeg
Size: 770 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130424/2a6ef113/compose-unknown-contact.jpg 


More information about the hotspot-runtime-dev mailing list