RFR (S): 8022452: Hotspot needs to know about Windows 8.1 and Windows Server 2012 R2
Coleen Phillimore
coleen.phillimore at oracle.com
Wed Aug 7 06:39:38 PDT 2013
It looks like the code under the case for all these releases, should be
different case statements for each, rather than these cascading 'if'
statements. And make 1668-1673 a new function returning si. So if we
have a new release, in general it will work because the default will
print out something. But a better default would be lines 1712-1717
which are dead code now.
Sorry, I know it's simple and urgent but this seems to be getting
increasingly ugly.
Thanks,
Coleen
On 8/6/2013 7:36 PM, Mikael Vidstedt wrote:
>
> Please review the following change:
>
> http://cr.openjdk.java.net/~mikael/webrevs/8022452/webrev
>
> The patch adds support to os_windows.cpp for recognizing the upcoming
> Windows versions: Windows 8.1 and Windows Server 2012 R2.
>
> The changed is based on the corresponding code on the JDK side[1][2][3].
>
> Thanks,
> Mikael
>
> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020191
> [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40221b09812f
> [3]
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/019463.html
>
More information about the hotspot-runtime-dev
mailing list