RFR: 8023188: Unsafe double store on bsd is broken

Yumin Qi yumin.qi at oracle.com
Fri Aug 16 17:24:34 PDT 2013


Thanks Dan for the review.

Thanks
Yumin

On 8/16/2013 4:51 PM, Daniel D. Daugherty wrote:
> Thumbs up!
>
> Please make sure you hear back from your original reviewers for this fix:
>
> 8016538: volatile double access via Unsafe.cpp is not atomic
> Summary: volatile jdouble load/store is not atomic, fix by using of 
> existing volatile jlong operations which are atomic for jdouble.
> Reviewed-by: kvn, vladidan, jrose
> Contributed-by: david.holmes at oracle.com
>
> Just to make sure that they are on board here.
>
> Dan
>
>
> On 8/16/13 5:13 PM, Yumin Qi wrote:
>> Hi,
>>
>>   Please have a review of this small change which is a typo mistake 
>> (but lead to this bug) in fix of
>>   8016538: volatile double access via Unsafe.cpp is not atomic
>>
>> http://cr.openjdk.java.net/~minqi/8023188/webrev00 
>> <http://cr.openjdk.java.net/%7Eminqi/8023188/webrev00>
>>
>>    Tested JPRT and java-concurrency-torture.jar (the original testing 
>> case)
>>
>> Thanks
>> Yumin
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130816/a164a73e/attachment.html 


More information about the hotspot-runtime-dev mailing list