Small CDE code review please Re: S RFR: 8012294: remove generic default handling

Coleen Phillimore coleen.phillimore at oracle.com
Mon Aug 26 08:13:12 PDT 2013


Karen,
This looks good.  Yes, it was good code.
Coleen

On 8/26/2013 11:05 AM, Karen Kinnear wrote:
> Thank you Keith for the code review, and thank you for writing the hard
> parts of this code. I totally appreciate the code review, and if you 
> have the time,
> there are some more coming up :-)
>
> thanks,
> Karen
>
> On Aug 26, 2013, at 10:22 AM, Keith McGuigan wrote:
>
>> Very sad to see it go, but the deletion looks fine to me.
>>
>> --
>> - Keith
>>
>>
>> On Mon, Aug 26, 2013 at 10:20 AM, Karen Kinnear 
>> <karen.kinnear at oracle.com <mailto:karen.kinnear at oracle.com>> wrote:
>>
>>     Could I please get a code review for this? I have another fix I
>>     need to apply to the same file so I'd like
>>     to get this in please.
>>
>>     This is totally code deletion cleanup.
>>
>>     thanks,
>>     Karen
>>
>>     On Aug 22, 2013, at 9:31 AM, Karen Kinnear wrote:
>>
>>     > Please review:
>>     >
>>     > webrev: http://cr.openjdk.java.net/~acorn/8012294/webrev/
>>     <http://cr.openjdk.java.net/%7Eacorn/8012294/webrev/>
>>     > http://bugs.sun.com/view_bug.do?bug_id=8012294
>>     >
>>     > This is a cleanup bug - fix 8013635 removed generic signature
>>     support from the vm
>>     > default method handling, but as a temporary fallback, put this
>>     under the develop flag
>>     > ParseGenericDefaults. This has been shaken out sufficiently
>>     that the old code under
>>     > that flag can now be removed, including ParseGenericDefaults
>>     and ParseAllGenericSignatures,
>>     > both of which were temporary develop flags for early lambda
>>     default method handling.
>>     >
>>     > tests:
>>     > java -XX:+ParseGenericDefaults -XX:+CompileTheWorld
>>     -Xbootclasspath/p:<mypath>db.jar - fails before change
>>     > java -XX:+ParseGenericDefaults - won't start VM after change
>>     > java -XX:+ParseAllGenericSignatures - won't start VM after change
>>     > jprt
>>     > defmeth tests (no new failures)
>>     > vm.quick.testlist in progress
>>     >
>>     > thanks,
>>     > Karen
>>     >
>>     >
>>     >
>>
>>
>>
>>
>> -- 
>> - Keith McGuigan <keith.mcguigan at alumni.unh.edu 
>> <mailto:keith.mcguigan at alumni.unh.edu>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130826/1244be5e/attachment-0001.html 


More information about the hotspot-runtime-dev mailing list