RFR: Lambda: 8026066 Invokeinterface throw ICCE for static methods
Karen Kinnear
karen.kinnear at oracle.com
Mon Dec 2 14:27:39 PST 2013
Many thanks for the review Yumin. Other review welcome.
thanks,
Karen
On Dec 2, 2013, at 12:05 AM, Yumin Qi wrote:
> Karen,
>
> Looks good to me.
>
> Thanks
> Yumin
>
> On 12/1/2013 5:59 PM, Karen Kinnear wrote:
>> Updated webrev to not include Harold's fix - which is included in the code review for
>> 8028438 which includes the test for that fix. The goal is to check both of these in
>> Tuesday Dec 3rd.
>>
>> webrev: http://cr.openjdk.java.net/~acorn/8026066.4/webrev
>>
>> Reran tests.
>>
>> thanks,
>> Karen
>>
>> On Nov 30, 2013, at 5:39 PM, Karen Kinnear wrote:
>>
>>> Please review:
>>>
>>> webrev: http://cr.openjdk.java.net/~acorn/8026066.3/webrev
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8026066
>>>
>>> Fix invokeinterface, invokespecial and invokestatic to all use common interface method
>>> resolution and invokeinterface and invokespecial to throw ICCE if a static method is found.
>>> Thanks to Harold for the fix for the linkResolver lookup_instance_method_in_klasses. This
>>> fix passes here and is specifically tested by 8028438 coming next for review.
>>>
>>> Note: causes hotspot/test/runtime/8026365/InvokeSpecialAnonTest.java to fail - should
>>> be fixed by Lois with 8028741 - skip static and non-public methods in j.l.Object.
>>> I added this failure comment to that bug, hopefully in the correct syntax to show up as a known bug
>>> and so Lois could use that as a partial test.
>>>
>>> Tests run:
>>> defmeth
>>> jck.lang, jck.vm
>>> jtreg java.util, java.lang, lambda
>>> jtreg langtools/test/lambdaShapes/.../test/vm
>>> 2009 invoke* tests
>>> hotspot jtreg: runtime, compiler
>>> nsk vm.quick, vm.mlvm
>>> itabletests/intfbug
>>>
>>> thanks,
>>> KAren
>
More information about the hotspot-runtime-dev
mailing list