RFR (S) 8027804: JCK resolveMethod test fails expecting AbstractMethodError

[Karen Kinnear]

Harold.

Code looks good. Great job.

And thank you for adding the comment around the lookup_instance_method_in_klasses calls.

Helpful if you also list tests run in the review request.

thanks,
Karen

On Dec 13, 2013, at 2:32 PM, harold seigel wrote:

> Hi,
> 
> Please review this updated fix for bug 8027804: http://cr.openjdk.java.net/~hseigel/bug_8027804.2/
> 
> This fixes a failure with JCK test vm/constantpool/resolveMethod/resolveMethod007/resolveMethod00705m2/resolveMethod00705m2.html
> 
> The bug involves a method in a subclass calling a default method in interface I where interface J implements I and contains an abstract method.  Instead of calling the default method, an AbstractMethodError should be thrown.
> 
> The changes in this new webrev fix additional problems caused by incorrectly finding overpass methods in superclasses and incorrectly finding default methods when searching transitive interfaces during resolution.
> 
> Thanks, Harold
> 
> -------- Original Message --------
> Subject:	RFR (S) 8027804: JCK resolveMethod test fails expecting AbstractMethodError
> Date:	Tue, 26 Nov 2013 14:19:19 -0500
> From:	harold seigel <harold.seigel at oracle.com>
> Organization:	Oracle Corporation
> To:	Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>
> 
> Hi,
> 
> Please review this small change to fix bug 8027804.
> 
> In cases where the maximally specific method is abstract, the fix 
> creates an AbstractMethodError exception and message.  This generates an 
> overpass method.  The overpass method then gets added to the default 
> methods table where it can be found during method resolution.
> 
> The fix was tested with the JCK lang and vm tests, the default methods 
> tests, ute vm.quick tests, and the jtreg hotspot, lang, and util tests.
> 
> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8027804/ 
> <http://cr.openjdk.java.net/%7Ehseigel/bug_8027804/>
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8027804
> 
> Thanks, Harold
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20131213/de68ba12/attachment.html