RFR: 4990369 SAJDI: visibleMethods() and methodsByName() return wrong visible methods

[Coleen Phillimore]

This looks good.   I was worried about this duplicating interface method 
resolution that the vm does but it just seems to visit the interfaces 
and list them all.   I think it's fine.
Thank you for fixing this long standing problem!
Coleen

On 12/16/2013 3:56 PM, serguei.spitsyn at oracle.com wrote:
> Staffan,
>
> It looks good to me.
>
> Thanks,
> Serguei
>
> On 12/16/13 1:32 AM, Staffan Larsen wrote:
>> Still looking for a review of this one…
>>
>> /Staffan
>>
>> On 20 nov 2013, at 14:05, Staffan Larsen <staffan.larsen at oracle.com> 
>> wrote:
>>
>>> This is more or less a copy of a previous patch that was made to JDI 
>>> [1], but this patch applies to the SA implementation of JDI.
>>>
>>> ReferenceType.visibleMethods() has some problems with diamond shaped 
>>> interface hierarchies. The solution here is to maintain a list of 
>>> interfaces that we have visited so that we do not visit interfaces 
>>> (above the top of the diamond) more than once.
>>>
>>> This change is targeted for jdk9 so I will hold on to it until the 
>>> repos open up.
>>>
>>> webrev: http://cr.openjdk.java.net/~sla/4990369/webrev.00/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-4990369
>>>
>>> Thanks,
>>> /Staffan
>>>
>>> [1] 
>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-November/013166.html
>>>
>