RFR (S) 8007434: Write tests for 8006298

Christian Törnqvist christian.tornqvist at oracle.com
Thu Feb 7 12:35:30 PST 2013


Thanks for the review :)

 

I think it's good that the test needs to be updated in case we change the output, this would make any accidental change of the output very apparent. 

 

Thanks,

Christian

 

From: Coleen Phillimore 
Sent: den 7 februari 2013 00:55
To: hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR (S) 8007434: Write tests for 8006298

 


These tests are really nice and a great model of how to write command line tests!   If we change the error output even slightly though, we'll have to change the tests.  Maybe this is okay.
thanks,
Coleen

On 2/6/2013 5:37 PM, Christian Törnqvist wrote: 

Hi everyone,

 

Here are some tests written for the recent change 8006298:

 

HYPERLINK "http://cr.openjdk.java.net/%7Ectornqvi/webrev/8007434/webrev.00/"http://cr.openjdk.java.net/~ctornqvi/webrev/8007434/webrev.00/

 

Thanks,

Christian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130207/9185314a/attachment.html 


More information about the hotspot-runtime-dev mailing list