RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

[Markus Grönlund]

Many thanks for your reviews!

 

Markus

 

From: Karen Kinnear 
Sent: den 17 juli 2013 17:06
To: Markus Grönlund
Cc: serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

 

Markus,

 

Looks good.

 

(Ok, I miss the comment about j.l.Thread :-)

ship it!

Karen

 

On Jul 16, 2013, at 11:48 AM, Markus Grönlund wrote:





Greetings,

 

Kindly asking for reviews for the following change in hsx24:

 

Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547

 

Webrev: http://cr.openjdk.java.net/~mgronlun/8020547/webrev01/

 

tracetypes.xml will declare a STRING type in order to support larger strings compared to existing UTF8 type (which is limited to a length of u2,  max 65535 chars).

 

I have also removed some stale comments.

 

Thank you

Markus

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130717/2000903a/attachment.html