RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

[Markus Grönlund]

Thanks Dan!

 

No technical reason for the *(star) placements in this file, it might be more readable for a human with a space added or something, I don't know, one of those human aspects again called preferences or something.

 

Cheers

Markus

 

From: Daniel D. Daugherty 
Sent: den 17 juli 2013 16:07
To: Markus Grönlund
Cc: serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

 

On 7/16/13 9:48 AM, Markus Grönlund wrote:



Greetings,

 

Kindly asking for reviews for the following change in hsx24:

 

Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547

 

Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Emgronlun/8020547/webrev01/"http://cr.openjdk.java.net/~mgronlun/8020547/webrev01/


src/share/vm/trace/traceDataTypes.hpp
    No comments.

src/share/vm/trace/tracetypes.xml
    line 277: type="TraceUnicodeString*" sizeop="sizeof_unicode(%)"/>

        The pointer type above and below this one have a space
        between the type name and the '*'. Any particular reason
        for the difference?

src/share/vm/trace/xinclude.mod
    This one threw me for a second when I was just looking at the
    patch. In the frames version, it is clear that you're removing
    an extra copyright block...

Thumbs up!

Dan





 

tracetypes.xml will declare a STRING type in order to support larger strings compared to existing UTF8 type (which is limited to a length of u2,  max 65535 chars).

 

I have also removed some stale comments.

 

Thank you

Markus

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130717/7d040e5d/attachment.html