code review for removal of unused Thread fields (8010257)

Karen Kinnear karen.kinnear at oracle.com
Tue Jun 4 20:29:50 PDT 2013


Looks good. Thanks for cleaning up,
Karen

On Jun 4, 2013, at 10:29 PM, Daniel D. Daugherty wrote:

> Thanks!
> 
> Dan
> 
> 
> On 6/4/13 7:32 PM, Coleen Phillimore wrote:
>> Reviewed.
>> Coleen
>> 
>> On 6/4/2013 8:23 PM, Daniel D. Daugherty wrote:
>>> Greetings,
>>> 
>>> This one isn't worth a webrev so here it is:
>>> 
>>> $ rgrep '_ScratchA|_ScratchB|ScratchA_offset|ScratchB_offset' agent src
>>> src/share/vm/runtime/thread.hpp: intptr_t _ScratchA, _ScratchB ; // Scratch locations for fast-path sync code
>>> src/share/vm/runtime/thread.hpp: static ByteSize ScratchA_offset() { return byte_offset_of(Thread, _ScratchA ); }
>>> src/share/vm/runtime/thread.hpp: static ByteSize ScratchB_offset() { return byte_offset_of(Thread, _ScratchB ); }
>>> 
>>> Removing the dead code looks like this:
>>> 
>>> $ hg diff src/share/vm/runtime/thread.hpp
>>> diff -r 2f004f9dc9e1 src/share/vm/runtime/thread.hpp
>>> --- a/src/share/vm/runtime/thread.hpp Tue Jun 04 01:06:50 2013 -0700
>>> +++ b/src/share/vm/runtime/thread.hpp Tue Jun 04 17:06:05 2013 -0700
>>> @@ -638,9 +638,6 @@ public:
>>>   jint _hashStateZ ;
>>>   void * _schedctl ;
>>> 
>>> - intptr_t _ScratchA, _ScratchB ; // Scratch locations for fast-path sync code
>>> - static ByteSize ScratchA_offset() { return byte_offset_of(Thread, _ScratchA ); }
>>> - static ByteSize ScratchB_offset() { return byte_offset_of(Thread, _ScratchB ); }
>>> 
>>>   volatile jint rng [4] ; // RNG for spin loop
>>> 
>>> May I please have one Reviewer and one reviewer?
>>> 
>>> Dan
>> 
> 



More information about the hotspot-runtime-dev mailing list