RFR (S) 7060111 : race condition in VMError::report_and_die()

[Zhengyu Gu]

Looks good to me.

-Zhengyu

On Jun 27, 2013, at 8:30 AM, frederic parain wrote:

> Please review this small fix:
> 
> http://cr.openjdk.java.net/~fparain/7060111/webrev.00/
> 
> Bug: 7060111 : race condition in VMError::report_and_die()
> 
> https://jbs.oracle.com/bugs/browse/JDK-7060111
> 
> The bug is well described in its report. This fix uses
> class static fields initialized at library load time
> instead of static local variables lazily initialized.
> 
> Test:
> 
> The race condition is so tricky (2 threads must invoke
> VMError::report_and_die() almost at the same time), that I
> didn't try to produce a unit test for it. But the fix is
> so simple that it doesn't look risky.
> 
> Thanks,
> 
> Fred
> 
> -- 
> Frederic Parain - Oracle
> Grenoble Engineering Center - France
> Phone: +33 4 76 18 81 17
> Email: Frederic.Parain at oracle.com