RFR 7007040: Check of capacity parameters in JNI PushLocalFrame is wrong

harold seigel harold.seigel at oracle.com
Sun Jun 30 06:27:34 PDT 2013


Hi Lois,

The change looks good to me, also.

Harold
On 6/28/2013 4:59 PM, Coleen Phillimore wrote:
>
> Lois,
>
> Looks good!   Can you copy the test case into the bug report so that 
> when we have support for native code in jtreg, someone can add it to 
> the test directory afterward.
>
> I think there's a nosqe-xxx keyword to also add to the bug to indicate 
> that the test wasn't added.
>
> Thanks,
> Coleen
>
> On 6/27/2013 4:04 PM, Lois Foltan wrote:
>>
>> Please review the following fix:
>>
>>     open webrev at http://cr.openjdk.java.net/~hseigel/bug_7007040/
>>
>> Bug: Check of capacity parameters in JNI PushLocalFrame is wrong
>>
>>     bug link at http://bugs.sun.com/view_bug.do?bug_id=7007040
>>     local bug link https://jbs.oracle.com/bugs/browse/JDK-7007040
>>
>> Summary of fix:
>>
>>     Within jni.cpp's support for JNI PushLocalFrame, the verification
>>     of the capacity parameter was incorrectly returning a JNI_OK
>>     value when a request was made outside of the boundary of
>>     0 thru MAX_REASONABLE_LOCAL_CAPACITY. For example a
>>     request of -1 or MAX_REASONABLE_LOCAL_CAPACITY+1.
>>
>> Tests:
>>
>>     jtreg, vm.quick.testlist, JCK vm & lang
>>     Individual Test7007040 test case for testing of boundary and 
>> outside of boundary conditions.
>>
>> Thank you,
>> Lois
>>
>>
>



More information about the hotspot-runtime-dev mailing list