RFR (S) CR 8008965: @Contended fails with classes having static fields

Coleen Phillimore coleen.phillimore at oracle.com
Mon Mar 11 08:11:01 PDT 2013


On 3/11/2013 10:40 AM, Aleksey Shipilev wrote:
> Friendly reminder.

I can push this.    Does the webrev point to the latest diffs?   Can you 
send me the lines for the commit:

bugid: synopsis
Summary: summary
Reviewed-by: reviewers
Contributed-by: your email

so I can cut/paste them when I do the hg commit.

Thanks,
Coleen

>
> -Aleksey.
>
> On 03/06/2013 12:15 PM, Aleksey Shipilev wrote:
>> Thanks for the review!
>>
>> I need a sponsor to push this.
>>
>> -Aleksey.
>>
>> On 03/06/2013 02:56 AM, Vladimir Kozlov wrote:
>>> Looks good to me.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 3/5/13 2:19 PM, Aleksey Shipilev wrote:
>>>> On 03/06/2013 02:13 AM, Coleen Phillimore wrote:
>>>>> On 03/05/2013 04:15 PM, Aleksey Shipilev wrote:
>>>>>> On 03/06/2013 01:01 AM, Coleen Phillimore wrote:
>>>>>>> This looks okay to me.  Can the 80003985 regression test be added
>>>>>>> to the
>>>>>>> hotspot or jdk test set?  I would like to see it in the webrev anyway.
>>>>>> Awwwwww. The test was lost from the 8003985 commit! Are you OK with
>>>>>> adding this test to this webrev, still leaving the 8003985 id for the
>>>>>> test?
>>>>> I think that's fine.
>>>> OK, here's the updated webrev (no code changes, only the test added):
>>>>     http://cr.openjdk.java.net/~shade/8008965/webrev.01/
>>>>
>>>> Thanks for the review!
>>>>
>>>> -Aleksey.
>>>>
>>>>
>>>>



More information about the hotspot-runtime-dev mailing list