Code Review request for new MallocMaxBytes option and fixed test (7030610, 7037122, 7123945)

[Daniel D. Daugherty]

On 3/11/13 6:01 PM, Ron Durbin wrote:
>
> All
>
> I have a code review readyfor:
>
> WEBREV http://javaweb.us.oracle.com/~rdurbin/7030610-webrev/0-hsx25/ 
> <http://javaweb.us.oracle.com/%7Erdurbin/7030610-webrev/0-hsx25/>
>

Thumbs up.

src/share/vm/runtime/globals.hpp
     No comments.

src/share/vm/runtime/os.cpp
     No comments.

src/share/vm/runtime/os.hpp
     No comments.

test/runtime/6878713/Test6878713.sh
     Should add an "@bug" line for 7037122 and 7123945also.

Dan


> 7030610 runtime/6878713/Test6878713.sh fails, Error. failed to clean 
> up files after test.
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7030610
>
> https://jbs.oracle.com/bugs/browse/JDK-7030610
>
> 7037122 runtime/6878713/Test6878713.sh is written incorrectly
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7037122
>
> https://jbs.oracle.com/bugs/browse/JDK-7037122
>
> 7123945 runtime/6878713/Test6878713.sh require about 2G of
>
> _http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7123945_
>
> https://jbs.oracle.com/bugs/browse/JDK-7123945
>
> Summary: Add new diagnostic option -XX:MallocMaxBytes=NNN and fix
>
> Test6878713.sh. Test6878713.sh is a security regression test with four 
> different
> failure modes.Three aredocumented in the defects above and the forth
>
> was found duringbug triage. The root cause of these failures can be
>
> traced back to two issues:Inconsistent test conditionsetup and error 
> handling.
>
> All four defect manifestations are fixed by this set of changes.
>
> New code built and test executed via JPRT test job; Linux ARM and
> Linux PPC version built, but not tested because ARM and PPC are
> currently build-only platforms in JPRT.
>
> As always, comments and questions are welcome.
>
> Ron
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130311/1ca8ac2f/attachment.html