JDK-8027113 fix code review

Daniel D. Daugherty daniel.daugherty at oracle.com
Thu Nov 14 16:20:35 PST 2013


On 11/14/13 4:49 PM, Ron Durbin wrote:
> JDK-8027113 decouple the '-XXaltjvm=<path>' option from the gamma launcher
>
> https://bugs.openjdk.java.net/browse/JDK-8027113
>
> Web URL http://cr.openjdk.java.net/~rdurbin/JDK-8027113-webrev/0-hsx25/

Thumbs up.


make/Makefile
     No comments.

make/hotspot.script
     No comments (please, update year in copyright)

src/os/bsd/vm/os_bsd.cpp
     No comments.

src/os/linux/vm/os_linux.cpp
     No comments.

src/os/solaris/vm/os_solaris.cpp
     No comments.

src/os/windows/vm/os_windows.cpp
     No comments.

src/share/tools/ProjectCreator/WinGammaPlatformVC10.java
     No comments.

src/share/vm/runtime/arguments.cpp
     No comments.

src/share/vm/runtime/arguments.hpp
     No comments.

Dan



>
> Internal URL:
> http://javaweb.us.oracle.com/~rdurbin/JDK-8027113-webrev/0-hsx25/
>
> Summary:
> Refactor the code so that it is no longer tightly coupled with the "gamma launcher".
> This change is based on a JDK8 hs25 repo, but will be checked into a JDK9 repo when one is ready.
>
>   This will allow work on the following bug to proceed:
>
>      JDK-8005262 possible gamma launcher issues
>
> Testing included:
>   JPRT run
>   Manual tests on Solaris 64 bit, Linux 32 bit and 64 bit, WindowsXP and Windows 7.



More information about the hotspot-runtime-dev mailing list