RFR (S) 8023167: JVM allows duplicate Runtime[In]VisibleTypeAnnotations attributes in ClassFile/field_info/method_info structures

harold seigel harold.seigel at oracle.com
Fri Sep 6 05:42:50 PDT 2013


Hi Coleen,

Thanks for your review.

Harold

On 9/5/2013 11:45 AM, Coleen Phillimore wrote:
>
> Harold, This looks good.   We need to refactor this duplicated code in 
> classFileParser in the future but not now.
> Thanks,
> Coleen
>
>
> On 9/4/2013 8:24 AM, harold seigel wrote:
>> Hi,
>>
>> Please review the following change to fix bug 8023167.  The fix 
>> checks if a Runtime[In]VisibleTypeAnnotation attribute already 
>> exists.  And, if so, generates a java.lang.ClassFormatError 
>> exception.  The fix was tested with the tests listed in the bug, JCK 
>> Lang and VM tests, JPRT, and UTE vm.quick tests and split_verifier 
>> tests.
>>
>> Open webrev at: http://cr.openjdk.java.net/~hseigel/bug_8023167/ 
>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8023167/>
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8023167
>>
>> Thanks! Harold
>



More information about the hotspot-runtime-dev mailing list