RFR (S) 8023167: JVM allows duplicate Runtime[In]VisibleTypeAnnotations attributes in ClassFile/field_info/method_info structures

harold seigel harold.seigel at oracle.com
Mon Sep 9 10:42:51 PDT 2013


Hi Zhengyu,

Thanks for catching this!  I changed the declarations of 
runtime_invisible_type_annotations_exists from "int" to "bool".

Harold

On 9/9/2013 12:11 PM, Zhengyu Gu wrote:
> Hi Harold,
>
> Why runtime_invisible_type_annotations_exists is declared as "int", 
> but used as boolean?
>
> Thanks,
>
> -Zhengyu
>
>  On Sep 4, 2013, at 8:24 AM, harold seigel wrote:
>
>> Hi,
>>
>> Please review the following change to fix bug 8023167.  The fix 
>> checks if a Runtime[In]VisibleTypeAnnotation attribute already 
>> exists.  And, if so, generates a java.lang.ClassFormatError 
>> exception.  The fix was tested with the tests listed in the bug, JCK 
>> Lang and VM tests, JPRT, and UTE vm.quick tests and split_verifier tests.
>>
>> Open webrev at: http://cr.openjdk.java.net/~hseigel/bug_8023167/ 
>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8023167/> 
>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8023167/>
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8023167
>>
>> Thanks! Harold
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130909/0e9ba64d/attachment.html 


More information about the hotspot-runtime-dev mailing list