RFR (S) JDK-8023735: runtime/XCheckJniJsig/XCheckJSig.java fails on MacOS X

Calvin Cheung calvin.cheung at oracle.com
Wed Sep 11 10:49:38 PDT 2013


Hi Harold,

The change looks good to me.
Just a minor suggestion:
I think you can just 'import java.io.File' instead of 'java.io.*'
and 'java.util.Map' instead of 'java.util.*'.

thanks,
Calvin

On 9/11/2013 7:52 AM, harold seigel wrote:
> Hi,
>
> Please review this small change to fix bug 8023735.  The fix changes 
> where the test looks for libjsig.dylib on Mac OS and also handles the 
> case when libjsig is not there.  The change was tested on Mac OS and 
> on Linux, with and without the existence of the libjsig file.
>
> open webrev: http://cr.openjdk.java.net/~hseigel/bug_8023735/
> <http://cr.openjdk.java.net/%7Ehseigel/bug_8023735/>
> bug: https://bugs.openjdk.java.net/browse/JDK-8023735
>
> Thanks! Harold



More information about the hotspot-runtime-dev mailing list