RFR (S) JDK-8023735: runtime/XCheckJniJsig/XCheckJSig.java fails on MacOS X

harold seigel harold.seigel at oracle.com
Thu Sep 12 08:42:35 PDT 2013


Hi David,

Thanks for adding this test to the needs_jdk group.

I'll hold off on this change until 64-bit overlays are gone.

Thanks, Harold

On 9/11/2013 11:12 PM, David Holmes wrote:
> On 12/09/2013 5:41 AM, harold seigel wrote:
>> Thanks for the review.  It should exist unless there are infra-structure
>> / setup problems.  Perhaps I'm just being paranoid.
>
> It won't exist at the jre/lib path when run against a JRE instead of a 
> full JDK. I just added it to the needs_jdk group in TEST.groups 
> because of that reason (change not yet pushed).
>
> Also the solaris section will start to fail once 64-bit overlays are 
> gone:
>
>  57         if (Platform.isSolaris()) {
>   58             // On Solaris, need to call the 64-bit Java directly 
> in order for
>   59             // LD_PRELOAD to work because libjsig.so is 64-bit.
>   60             java_program = jdk_path + "/jre/bin/" + os_arch + 
> "/java";
>
> David
>
>> Harold
>>
>> On 9/11/2013 3:22 PM, Gerard Ziemski wrote:
>>> Looks good.
>>>
>>> Why would the libjsig library not exist though?
>>>
>>>
>>> cheers
>>>
>>> On 9/11/2013 9:52 AM, harold seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this small change to fix bug 8023735.  The fix changes
>>>> where the test looks for libjsig.dylib on Mac OS and also handles the
>>>> case when libjsig is not there.  The change was tested on Mac OS and
>>>> on Linux, with and without the existence of the libjsig file.
>>>>
>>>> open webrev: http://cr.openjdk.java.net/~hseigel/bug_8023735/
>>>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8023735/>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8023735
>>>>
>>>> Thanks! Harold
>>>>
>>>>
>>>
>>



More information about the hotspot-runtime-dev mailing list