Fwd: RFR (M) : JDK-7149464 : [TESTBUG] Test runtime/7020373/Test7020373.sh failed to clean up files after test

[Mikhailo Seledtsov]

Hi Dan, Calvin, David,

  Thank you for the review.

Misha

On 9/12/2013 4:35 PM, Daniel D. Daugherty wrote:
> > Webrev: http://cr.openjdk.java.net/~mseledtsov/7149464/webrev.01/
>
> test/runtime/ClassFile/JsrRewriting.java
>     nit line 69:  className );
>         Delete space before ')'.
>
>     line 76: "insufficient memory"
>         Originally the test looked for a failed memory allocation
>         over 2GB because we wanted to make sure we got the "right"
>         memory allocation failure. In hindsight, that was way too
>         brittle of a check.
>
>         What you have here is better.
>
>     line 91: " stdout: [" + analyzer.getOutput() + "];\n" +
>     line 92: " exitValue = " + analyzer.getExitValue() + "\n";
>     line 96: "any of the following expected messages: \n");
>     line 98: msg.append(expected).append(" \n");
>         All of these '\n' uses should be System.lineSeparator().
>
> test/runtime/ClassFile/JsrRewritingTestCase.jar
>     No comments.
>
> Dan
>
>
> On 9/11/13 10:46 AM, Mikhailo Seledtsov wrote:
>> Hi,
>>
>>     JBS: https://bugs.openjdk.java.net/browse/JDK-7149464
>>         This bug description is Oracle internal.
>>         According to the bug, in certain cases JTReg failed to delete 
>> the temporary files. In addition to that, the test consumed excessive 
>> time and resources on the system.
>>
>>     Webrev:
>> http://cr.openjdk.java.net/~mseledtsov/7149464/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Emseledtsov/7149464/webrev.01/>
>>
>>     Testing:
>>         JPRT using this specific test 
>> (2013-09-10-135828.mseledtsov.bugFixing01)
>>
>>     Comments:
>>        - rewrote this test in Java. This had couple of benefits. 
>> Following general direction of rewriting JTReg tests in Java and 
>> avoiding portability issues. Also, the shell script created temporary 
>> files for output analysis, which in case of test taking too long or 
>> failure, in certain cases,  could not be deleted since the handle was 
>> still active. The new test uses OutputAnalyzer utility for this 
>> purpose, thus not needing the temporary output files, and solving the 
>> problem.
>>        - after discussions with the Run-time team, the limit for 
>> malloc'ed memory was added to the test by using 
>> -XX:MallocMaxTestWords, thus fixing the issue of using excessive 
>> resources
>>
>> Thank you,
>> Misha
>>
>>
>>
>>
>