RR(S): JDK-8022616 u4 should not be used as a type for thread_id

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Tue Sep 24 15:22:13 PDT 2013


Looks good.

Thanks,
Serguei

On 9/24/13 12:20 PM, Dmitry Samersoff wrote:
> Staffan and Yumin,
>
> Thank you for feedback.
>
> Fixed (in place, please press shift-reload)
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
>
> -Dmitry
>
> On 2013-09-24 11:57, Dmitry Samersoff wrote:
>> Please review changes:
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
>>
>> Story:
>>
>> Tracing framework expect u4 as an id of thread
>>
>> pthread_t chosen as a tread id for variety of BSD platforms couldn't be
>> converted to u4 so it cause compilation failure on BSD x64
>>
>> Solution:
>>
>> Change thread_id to pid_t and get this id  directly from kernel, the
>> same manner as Linux code does. Mac Os X still uses mach_port instead of
>> thread id.
>>
>> Tested on FreeBSD and OpenBSD and also code passed jprt.
>>
>> -Dmitry
>>
>



More information about the hotspot-runtime-dev mailing list