RFR: 8022187 Missing ResourceMark crash when assertion using FormatBufferResource fails

Zhengyu Gu zhengyu.gu at oracle.com
Mon Sep 30 12:52:37 PDT 2013


Thanks for the review.

-Zhengyu

On 9/30/2013 3:11 PM, Coleen Phillimore wrote:
>
> This looks good.
> Coleen
>
> On 09/30/2013 11:10 AM, Zhengyu Gu wrote:
>> Please review a simple fix, that uses stack memory for formatting 
>> assertion message instead of resource memory.
>>
>> Array is an utility class, which can be used anywhere, there is no 
>> guarantee to have ResourceMark setup for using resource memory.
>> Using stack memory here is more proper, given buffer size is only 256 
>> bytes.
>>
>>
>> JIRA bug: https://bugs.openjdk.java.net/browse/JDK-8022187
>> Webrev: http://cr.openjdk.java.net/~zgu/8022187/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Ezgu/8022187/webrev.00/>
>>
>> Test:
>>   - JPRT
>>  - Jteg test compiler/8010927/Test8010927.java on Linux x32
>>
>> Thanks,
>>
>> -Zhengyu
>>
>>
>



More information about the hotspot-runtime-dev mailing list