RFR (S): 8039146: Fix 64-bit store to int JNIHandleBlock::_top

Coleen Phillimore coleen.phillimore at oracle.com
Mon Apr 7 17:41:05 UTC 2014


The change looks fine.  I can sponsor it unless someone else would like to.
Thanks,
Coleen

On 4/7/14, 6:07 AM, Lindenmaier, Goetz wrote:
>
> Hi,
>
> could I please get a review of this change?  It fixes a rather
>
> obvious error, and is really simple.
>
> Is runtime the wrong mainling list for interpreter changes? Should I
>
> post to comp?
>
> Best regards,
>
> Goetz.
>
> *From:*Lindenmaier, Goetz
> *Sent:* Donnerstag, 3. April 2014 15:33
> *To:* hotspot-runtime-dev at openjdk.java.net
> *Subject:* RFR (S): 8039146: Fix 64-bit store to int JNIHandleBlock::_top
>
> Hi,
>
> please review an test this small fix to the interpreters.  I please need
>
> a sponsor.
>
> http://cr.openjdk.java.net/~goetz/webrevs/8039146-intSt/webrev.00/ 
> <http://cr.openjdk.java.net/%7Egoetz/webrevs/8039146-intSt/webrev.00/>
>
> JNIHandleBlock::_top is an int field. Various places store into
>
> this field using a pointer store. On 64-bit platforms
>
> this can cause errors.
>
> This change adapts the corresponding operations on sparc
>
> and both x86 variants to use fixed 32-bit operations.
>
> Best regards,
>
>   Goetz.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20140407/0f10ad4b/attachment-0001.html>


More information about the hotspot-runtime-dev mailing list