RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

[Ivan Gerasimov]

Thanks Kelly and David!

On 19.08.2014 6:14, David Holmes wrote:
> On 19/08/2014 9:04 AM, Kelly O'Hair wrote:
>>   454   if (vm_getting_terminated && thread->is_Java_thread()) {
>>   455     JavaThread* java_thread = (JavaThread*)thread;
>>   456     if (java_thread && 
>> java_lang_Thread::is_daemon(java_thread->threadObj())) {
>>   457       return 70115;
>>   458     }
>>
>> Seems like the check for java_thread being null on line 456 can never 
>> happen, because it was assigned thread which was dereferenced on line 
>> 454.
>> Maybe on line 454 you should check to make sure thread is not null 
>> and skip the check for java_thread being null?
>
> Neither thread nor java_thread can be NULL.
>
Yes, I'll remove this unnecessary check.

Sincerely yours,
Ivan


>> Just comments from the peanut gallery. ;)
>
> Ditto :)
>
> David H.
>
>
>> -kto
>>
>> On Aug 18, 2014, at 3:14 PM, Daniel D. Daugherty wrote:
>>
>>>
>>> On 8/18/14 3:19 PM, Ivan Gerasimov wrote:
>>>> Hello!
>>>>
>>>> This is a request to temporarily add some instrumentation code to 
>>>> hotspot to help diagnose the intermittent failure on Windows, which 
>>>> results in a wrong exit code of (sub-)process.
>>>>
>>>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8055338
>>>> WEBREV: http://cr.openjdk.java.net/~igerasim/8055338/0/webrev/
>>>
>>> src/os/windows/vm/os_windows.cpp
>>>     No comments.
>>>
>>> src/share/vm/runtime/java.cpp
>>>     No comments.
>>>
>>> Good luck with the hunt! Many of us have looked for this bug
>>> for years off and on...
>>>
>>> Dan
>>>
>>>
>>>>
>>>> Sincerely yours,
>>>> Ivan
>>>>
>>>
>>
>
>