RFR (XS): 8066670 - PrintSharedArchiveAndExit does not exit the VM when the archive is invalid

[David Holmes]

Hi Ioi,

On 4/12/2014 8:32 PM, Ioi Lam wrote:
> Hi Folks,
>
> Please review a small fix:
>
> https://bugs.openjdk.java.net/browse/JDK-8066670
> http://cr.openjdk.java.net/~iklam/8066670-PrintSharedArchiveAndExit/
>
> Summary of fix:
>
> Do not set UseSharedSpaces to falseif PrintSharedArchiveAndExit is enabled.
>
>      After this fix, the JVM correctly exits when
> PrintSharedArchiveAndExit is enabled and an invalid archive is encountered.

The change to metaspaceShared.cpp is fine.

In filemap.cpp I'm less clear on the logic. It seems that if 
_validating_classpath_entry_table is false then we will still continue, 
even if PrintSharedArchiveAndExit is true.

>
>      New test cases are in closed source code.

Begs the question as to why there can't be an open test for this?

Thanks,
David

> Tests:
>
>      JPRT
>      JTREG
>
>
>