RFR: JDK-8033464 - Linux code cleanup

Gerald Thornbrugh gerald.thornbrugh at oracle.com
Fri Mar 21 14:43:37 UTC 2014


Hi Harold,

There was a long discussion on the assert between myself, Dmitry, Coleen
and Dan.  The result was that imin and imax should not be equal and to
verify this I ran complete JPRT, UTE and Aurora runs with fast debug bits to
verify that the assert was correct.

Does that answer your questions?

Thanks,

Gerald Thornbrugh
> Hi Gerald,
>
> Is it possible for imin and imax to be equal in 
> get_stack_commited_bottom() ?
>
> Could you also run the hotspot jtreg tests?
>
> Thanks, Harold
>
> On 3/21/2014 10:11 AM, Gerald Thornbrugh wrote:
>> Hi,
>>
>> I am a member of the Oracle Hotspot group and there is an initiative 
>> to clean up
>> things like uninitialized variables and unclosed file descriptors in 
>> JDK8. This is a
>> backport of fixes that have already been putback into JDK9. I have 
>> run UTE and
>> JPRT tests on Linux machines without problems. The below webrev show 
>> the fixes for
>> the Linux area.
>>
>> Bug:
>>
>> This bug is not visible because it has been marked as Oracle 
>> confidential.
>>
>> JDK-8033464 describes a JDK8 Linux specific code cleanup to address
>> possible uninitialized variables and unclosed file descriptors. These 
>> issues
>> were addressed in the fix.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8033464
>>
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~dcubed/for_gthornbr/8033464-webrev/0-jdk8u-hs-dev/ 
>> <http://cr.openjdk.java.net/%7Edcubed/for_gthornbr/8033464-webrev/0-jdk8u-hs-dev/> 
>>
>>
>>
>> Please review my changes and let me know if you have questions.
>>
>> Thanks,
>>
>> Gerald Thornbrugh
>



More information about the hotspot-runtime-dev mailing list