RFR(XXS) update 8u fix for 8028073 now that 8028280 is backported to 8u (8038274)

Coleen Phillimore coleen.phillimore at oracle.com
Tue Mar 25 22:05:38 UTC 2014


this is fine.
Coleen

On 3/25/14 6:03 PM, Daniel D. Daugherty wrote:
> I put this in the bug report, but maybe putting it in
> the e-mail thread will make things easier:
>
> Daniel Daugherty added a comment - 2014-03-24 16:51
> Here's the remaining diffs between the 8u-hs-dev and JDK9-hs versions 
> of the file:
>
> $ diff src/share/vm/runtime/objectMonitor.cpp{,.jdk9-hs}
> 237c237
> < // dequeue operation after acquisition (in the ::enter() epilog) and
> ---
> > // dequeue operation after acquisition (in the ::enter() epilogue) and
> 692c692
> < // ST Responsible=null; MEMBAR (in enter epilog - here)
> ---
> > // ST Responsible=null; MEMBAR (in enter epilogue - here)
> 2058c2058
> < // Slighty racy, but benign ...
> ---
> > // Slightly racy, but benign ...
>
>
> Anyone? :-)
>
> Dan
>
>
> On 3/25/14 10:53 AM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> Mr Simms' fix for the following bug has been backported to JDK8u-hs-dev:
>>
>>     8028280 ParkEvent leak when running modified runThese which only
>>             loads classes
>>     https://bugs.openjdk.java.net/browse/JDK-8028280
>>
>> which allows the JDK8u-hs-dev version of the fix for the following bug
>> to be updated to match the JDK9-hs version:
>>
>>     8028073 race condition in ObjectMonitor implementation causing 
>> deadlocks
>>     https://bugs.openjdk.java.net/browse/JDK-8028073
>>
>> This minor tweak is being done with the following bug:
>>
>>     8038274 update 8u fix for 8028073 now that 8028280 is backported 
>> to 8u
>>     https://bugs.openjdk.java.net/browse/JDK-8038274
>>
>> Here is the webrev:
>>
>> http://cr.openjdk.java.net/~dcubed/8038274-webrev/0-jdk8u-hs-dev/
>>
>> Since this is effectively a backport from JDK9-hs -> JDK8u-hs-dev,
>> I'm looking for one sanity check (R)eviewer or reviewer from the
>> original set of folks that reviewed 8028073:
>>
>>     The JDK9 reviewers:  dholmes, sspitsyn, dice, acorn
>>     The JDK8u reviewers: rdurbin, acorn, sspitsyn, dsimms, dholmes
>>
>> Because I'm paranoid, I'm running the same set of vm.quick testing
>> Adhoc test jobs and StressMonitorWait testing that was done on the
>> JDK9 and JDK8u versions of the fix.
>>
>> Thanks, in advance, for any comments, questions or suggestions.
>>
>> Dan
>>
>>
>



More information about the hotspot-runtime-dev mailing list